[OFFICE-3933] Allow <office:binary-data> in <draw:fill-image> - OASIS Technical Committees Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: ODF 1.2
Fix Version/s: ODF 1.3
Component/s: Document Structure, Graphics, Part 3 (Schema) [1.2: 1]
Labels:
None

Proposal:
Hide

Change the description in section 16.40.6 <draw:fill-image> to this:

The <draw:fill-image> element specifies either a link to a bitmap resource or contains an image in the <office:binary-data> child element. Producers shall not write the <office:binary-data> child element in case the document is represented as a package.
Fill image are not available as automatic styles.

Change the schema this way:

--- OpenDocument-v1.2-os-schema.rng 2017-08-23 01:39:12.187248700 +0200 +++ OpenDocument-v1.2-os-schema_drawFillImage.rng 2017-08-28 22:38:25.626770100 +0200 @@ -14021,27 +14021,17 @@ </interleave> </define> <define name="draw-fill-image"> <element name="draw:fill-image"> <ref name="draw-fill-image-attlist"/> - <attribute name="xlink:type"> - <value>simple</value> - </attribute> - <attribute name="xlink:href"> - <ref name="anyIRI"/> - </attribute> - <optional> - <attribute name="xlink:show"> - <value>embed</value> - </attribute> - </optional> - <optional> - <attribute name="xlink:actuate"> - <value>onLoad</value> - </attribute> - </optional> - <empty/> + <choice> + <group> + <ref name="common-draw-data-attlist"/> + <empty/> + </group> + <ref name="office-binary-data"/> + </choice> </element> </define> <define name="draw-fill-image-attlist"> <interleave> <attribute name="draw:name">
Show
Change the description in section 16.40.6 <draw:fill-image> to this: The <draw:fill-image> element specifies either a link to a bitmap resource or contains an image in the <office:binary-data> child element. Producers shall not write the <office:binary-data> child element in case the document is represented as a package. Fill image are not available as automatic styles. Change the schema this way: --- OpenDocument-v1.2-os-schema.rng 2017-08-23 01:39:12.187248700 +0200 +++ OpenDocument-v1.2-os-schema_drawFillImage.rng 2017-08-28 22:38:25.626770100 +0200 @@ -14021,27 +14021,17 @@ </interleave> </define> <define name="draw-fill-image"> <element name="draw:fill-image"> <ref name="draw-fill-image-attlist"/> - <attribute name="xlink:type"> - <value>simple</value> - </attribute> - <attribute name="xlink:href"> - <ref name="anyIRI"/> - </attribute> - <optional> - <attribute name="xlink:show"> - <value>embed</value> - </attribute> - </optional> - <optional> - <attribute name="xlink:actuate"> - <value>onLoad</value> - </attribute> - </optional> - <empty/> + <choice> + <group> + <ref name="common-draw-data-attlist"/> + <empty/> + </group> + <ref name="office-binary-data"/> + </choice> </element> </define> <define name="draw-fill-image-attlist"> <interleave> <attribute name="draw:name">

Description

If you use the packed format you can use a folder 'Pictures' (or 'media' in case of PowerPoint) with an image e.g. XYZ.png. And in <office:styles> you have <draw:fill-image draw:name="foo" xlink:href="Pictures/XYZ.png" xlink:type="simple" xlink:show="embed" xlink:actuate="onLoad"/>

But in flat format you cannot include the image. In contrast to a <style:background-image> the <draw:fill-image> has no child element <office:binary-data>.

This proposal adds the <office:binary-data> to <draw:fill-image>.

Because the use of <office:binary-data> is not allowed in ODF1.2, consumers might not be able to interpret it, in case the document is represented as a package. On the other hand I know only LibreOffice to write and read flat ODF, and currently LibreOffice already writes this element. So there is no harm if the element is present in flat ODF. Therefore I have restricted the use of the <office:binary-data> child element to flat ODF.

Allow <office:binary-data> in <draw:fill-image>

Details

Description

Attachments

Activity

People

Dates