Uploaded image for project: 'OASIS Virtual I/O Device (VIRTIO) TC'
  1. OASIS Virtual I/O Device (VIRTIO) TC
  2. VIRTIO-130

4.1.4.5 ISR status capability diagram incorrect

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: virtio 1.0 cs01, virtio 1.0 cs02
    • Fix Version/s: virtio 1.0 cs03
    • Labels:
      None
    • Environment:

      Rusty Russell <rusty@rustcorp.com.au>

      Description

      4.1.4.5 ISR status capability diagram has the "Device Configuration Interrupt " as bit 0, and the "Queue Interrupt" as bit 1. This is the wrong way around: it disagrees with the legacy implementations, as well as the spec elsewhere:

      4.1.5.3 Virtqueue Interrupts From The Device

      If an interrupt is necessary for a virtqueue, the device would typically act as follows:

      If MSI-X capability is disabled:
      Set the lower bit of the ISR Status field for the device.

      ...
      4.1.5.4 Notification of Device Configuration Changes

      Some virtio PCI devices can change the device configuration state, as reflected in the device-specific configuration region of the device. In this case:

      If MSI-X capability is disabled:
      Set the second lower bit of the ISR Status field for the device.
      ...

        Attachments

          Activity

            People

            • Assignee:
              mstsirkin Michael S. Tsirkin
              Reporter:
              rusty Rusty Russell (Inactive)
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: