Improve Semantics of signalPercent

XMLWordPrintable

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Environment:

      Toby Considine

    • Hide

      Recomend that it be renamed signalMultiplier, normally a number between 0 and 1, and have thereby identical semantics to priceMultiplier.

      Show
      Recomend that it be renamed signalMultiplier, normally a number between 0 and 1, and have thereby identical semantics to priceMultiplier.
    • Hide

      renamed signalMultiplier, normally a number between 0 and 1, and have thereby identical semantics to priceMultiplier.

      Show
      renamed signalMultiplier, normally a number between 0 and 1, and have thereby identical semantics to priceMultiplier.

      One of the signals, signalPercent has very muddy semantics. It is currently a float, but w/o special pleading its meaing and use is unclear. Percent generally is divided by a 100 and them multiplied by its base. For this comment, assume it only makes sense between 0% and 100%, although clearly greater than 100 and even negative numbers could make sense.

      Is this number

      • a number between 0 and 100?
      • a number between 0 and 1?
      • something else?

            Assignee:
            Girish Ghatikar (Inactive)
            Reporter:
            Toby Considine (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: