Virtio SCSI

max_channel, max_target, max_lun

Are comparisons here less-than or less-than-or-equal? Both interpretations are in the fields.

Could we standardize on returning the VIRTIO_SCSI_S_TRANSPORT_FAILURE code for in flight commands when the device is unplugged.

The spec states “all task attributes may be mapped to SIMPLE by the device” - this makes S_ORDERED, S_HEAD_OF_QUEUE or S_ACA commands impossible to issue - plus some commands have implicit head of queue attribute conflicting with this statement.

VIRTIO_SCSI_S_OVERRUN - could the length referred to be clarified - the virtio buffers or the allocation_length in the CBD?

VIRTIO_SCSI_T_TMF_LOGICAL_UNIT_RESET - what is the expected behavior when commands are in flight? What about an incomplete TMF_ABORT?