virtio_blk_req.data size - Section 5.2.6 - version 1.1 draft 01

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major
    • virtio 1.1 cs01
    • Affects Version/s: virtio 1.1 csprd01
    • None
    • Environment:

      Thomas Huth <thuth@redhat.com>
      "Savir, Gil" <gil.savir@intel.com>

    • Hide

      I suggest to add to the spec clarification, that for DISCARD or WRITE_ZEROES requests, data-field is not required to
      be with size that is 512 Bytes multiplication.

      Show
      I suggest to add to the spec clarification, that for DISCARD or WRITE_ZEROES requests, data-field is not required to be with size that is 512 Bytes multiplication.
    • Hide

      This is a duplicate report that was resolved as part of resolution of
      https://github.com/oasis-tcs/virtio-spec/issues/32
      bef3ff7 virtio-blk: document data[] size constraints

      Show
      This is a duplicate report that was resolved as part of resolution of https://github.com/oasis-tcs/virtio-spec/issues/32 bef3ff7 virtio-blk: document data[] size constraints

      In version 1.1 draft 01 - Section 5.2.6 - struct virtio_blk_req definition:

      Data field is defined as array of 512 Byte entries as follows:
      u8 data[][512];
      It makes sense for IN and OUT requests, since defined for read/write sizes that are 512 Bytes multiplication.
      However, it is confusing when used for DISCARD or WRITE_ZEROES requests, since virtio_blk_discard_write_zeroes struct size is 16
      +Bytes.

      Is implying that DISCARD and WRITE_ZEROES requests must use data-field sizes that are 512 Bytes multiplication as well?

      If yes, than the device can't tell how many virtio_blk_discard_write_zeroes structs reside within data-field. In that case -
      +indication for number of virtio_blk_discard_write_zeroes structs needs to be added.

            Assignee:
            Unassigned
            Reporter:
            Michael Tsirkin (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: