Uploaded image for project: 'OASIS Virtual I/O Device (VIRTIO) TC'
  1. OASIS Virtual I/O Device (VIRTIO) TC
  2. VIRTIO-54

4.1.2.5: Legacy: PCI Device Layout: fix PCI header fields

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: virtio 1.0 csprd02
    • Labels:
      None
    • Proposal:
      Hide

      Fixed in the following patch: https://www.oasis-open.org/apps/org/workgroup/virtio/email/archives/201401/msg00055.html

      4.1.2.5: Legacy: PCI Device Layout: fix PCI header fields order

      The order of the fields in the legacy PCI header seems to get
      messed up in the new spec, with the "Queue Address" moved
      behind "Queue Notify". According to the 0.9.5 version of the spec
      it should be:

      • Device Features 32
      • Driver Features 32
      • Queue Address 32
      • Queue Size 16
      • Queue Select 16
      • Queue Notify 16
      • Device Status 8
      • ISR Status 8

      Signed-off-by: Pawel Moll <pawel.moll@arm.com>

      Show
      Fixed in the following patch: https://www.oasis-open.org/apps/org/workgroup/virtio/email/archives/201401/msg00055.html 4.1.2.5: Legacy: PCI Device Layout: fix PCI header fields order The order of the fields in the legacy PCI header seems to get messed up in the new spec, with the "Queue Address" moved behind "Queue Notify". According to the 0.9.5 version of the spec it should be: Device Features 32 Driver Features 32 Queue Address 32 Queue Size 16 Queue Select 16 Queue Notify 16 Device Status 8 ISR Status 8 Signed-off-by: Pawel Moll <pawel.moll@arm.com>
    • Resolution:
      Hide

      applied in r198 | hornet | 2014-01-29 11:13:24 +0000 (Wed, 29 Jan 2014) | 21 lines
      approved 11 February 2014

      Show
      applied in r198 | hornet | 2014-01-29 11:13:24 +0000 (Wed, 29 Jan 2014) | 21 lines approved 11 February 2014

      Description

      The order of the fields in the legacy PCI header seems to get messed up in the new spec, with p. 4.1.2.5 "Legacy Interfaces: A Note on PCI Device Layout" saying:

      • Device Features 32
      • Driver Features 32
      • Queue Size 32 <-------------- !!!
      • Queue Select 16
      • Queue Notify 16
      • Queue Address 16 <------------ !!!
      • Device Status 8
      • ISR Status 8

      According to the 0.9.5 version of the spec it should be:

      • Device Features 32
      • Driver Features 32
      • Queue Address 32
      • Queue Size 16
      • Queue Select 16
      • Queue Notify 16
      • Device Status 8
      • ISR Status 8

        Attachments

          Activity

            People

            • Assignee:
              hornet Pawel Moll (Inactive)
              Reporter:
              hornet Pawel Moll (Inactive)
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: