Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: virtio 1.0 csprd01
    • Fix Version/s: virtio 1.0 csprd02
    • Labels:
      None
    • Environment:

      Keywords

    • Proposal:
      Hide

      Check all usages of SHOULD and should to make sure the correct version has been chosen and that the usage is consistent across the specification.

      Patch: https://lists.oasis-open.org/archives/virtio-comment/201403/msg00004.html

      Show
      Check all usages of SHOULD and should to make sure the correct version has been chosen and that the usage is consistent across the specification. Patch: https://lists.oasis-open.org/archives/virtio-comment/201403/msg00004.html
    • Resolution:
      Hide

      accepted on 2014-03-11
      applied in commit r321

      Show
      accepted on 2014-03-11 applied in commit r321

      Description

      SHOULD appears 12 times and should appears 67 times.

      Some of the lower case uses of "should" appear to be in non-normative text that should be notes. But in other cases, it appears to be the equivalent of "SHOULD."

      From 3.1 Device Initialization:

      *****
      the driver SHOULD set the FAILED status bit to indicate that it has given up on the device (it can reset the device later to restart if desired).
      *****

      From 3.2.2 Receiving Used Buffers from the Device

      *****
      For each ring, the driver should then disable interrupts by writing VRING_AVAIL_F_NO_INTERRUPT flag in avail structure, if required.
      *****

      The "shoulds" in those two cases have very different meaning for conforming to VIRTIO.

      The first is RFC2119 "SHOULD" and the second is just ordinary should, really non-normative.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              patrick Patrick Durusau
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: