Uploaded image for project: 'OASIS Virtual I/O Device (VIRTIO) TC'
  1. OASIS Virtual I/O Device (VIRTIO) TC
  2. VIRTIO-81

MUST vs. must - Improper use of keywords 65 cases

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: virtio 1.0 csprd01
    • Fix Version/s: virtio 1.0 csprd02
    • Labels:
      None
    • Proposal:
      Hide

      Review all instances of "Must/must" to see if they should be MUST and change as appropriate.

      Patch: https://lists.oasis-open.org/archives/virtio-comment/201403/msg00003.html

      Show
      Review all instances of "Must/must" to see if they should be MUST and change as appropriate. Patch: https://lists.oasis-open.org/archives/virtio-comment/201403/msg00003.html
    • Resolution:
      Hide

      accepted on 2014-03-11
      applied in commit r318

      Show
      accepted on 2014-03-11 applied in commit r318

      Description

      There are 65 uses of Must/must and 51 uses of MUST in this draft.

      Many of the 65 uses of Must/must appear to be normative statements.

      Changing a Must or must to uppercase, MUST will trigger an additional public review b/c it changes the conformance requirements of the specification.

      Suggest that all uses of Must/must be reviewed at this early stage and modified as appropriate.

      Examples:

      Under 4.3.1 Basic Concepts, I find:

      *****
      The virtio-ccw device acts like a normal channel device, as speciļ¬ed in [S390 PoP] and [S390 Common I/O]. In particular:

      • A device must post a unit check with command reject for any command it does not support.
        *****

      I am assuming, based on the normative references, that the "must" in the first bullet point should be MUST. Yes? (there are several others in that list)

      Under 4.3.2.1.1 Legacy Interfaces: A Note on Setting the Virtio Revision, I find at the end of the first paragraph:

      *****
      A transitional driver must operate the device as if it had been able to set revision 0.
      *****

      I am assuming you mean that to be MUST, that is it isn't optional, in some cases, etc. but MUST. Yes?

      I did not review the MUST instances at all. But I would suggest a close reading just to be sure they are all correct. Certainly all of the must instances should be individually checked.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              patrick Patrick Durusau
            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: