Details

    • Resolution:
      Hide

      Will address in ODF 1.3 as follows:

      Change the syntax for command T and U

      from

      (x y w h t0 t1) +

      to

      (x y wR hR t0 t1) +

      and change the description in command T

      from

      The ellipse is specified by the center(x, y), the size(w, h) and the start-angle t0 in degrees and end-angle t1 in degrees.

      to

      The ellipse is specified by the center(x, y), the width 2*wR, the height 2*hR, and the start-angle t0 in degrees and end-angle t1 in degrees.

      Show
      Will address in ODF 1.3 as follows: Change the syntax for command T and U from (x y w h t0 t1) + to (x y wR hR t0 t1) + and change the description in command T from The ellipse is specified by the center(x, y), the size(w, h) and the start-angle t0 in degrees and end-angle t1 in degrees. to The ellipse is specified by the center(x, y), the width 2*wR, the height 2*hR, and the start-angle t0 in degrees and end-angle t1 in degrees.

      Description

      The definition of T is the following:

      Draws a segment of an ellipse. The ellipse is
      specified by the center(x, y), the size(w, h)
      and the start-angle t0 in degrees and end-
      angle t1 in degrees. The segment is drawn
      clockwise.

      What is meant by w and h. Is it the size of the full ellipse?

      When working on the implementation one of the Calligra developers noted differences
      in what OOo/MSO are doing to what Calligra is doing. OOo and MSO use w and h as radii.
      Calligra uses w and h as diameter.

      Which of the two behaviours is correct?

      The specification should clearly state if radii or diameter should be used for this
      two values.

        Attachments

          Activity

          Hide
          rcweir Robert Weir (Inactive) added a comment -

          SVG defines this as the radii of the ellipse, both for shapes and arcs:

          http://www.w3.org/TR/SVG/shapes.html#EllipseElement
          http://www.w3.org/TR/SVG/paths.html#PathDataEllipticalArcCommands

          I propose we do the same. We're trying to converge on SVG.

          Show
          rcweir Robert Weir (Inactive) added a comment - SVG defines this as the radii of the ellipse, both for shapes and arcs: http://www.w3.org/TR/SVG/shapes.html#EllipseElement http://www.w3.org/TR/SVG/paths.html#PathDataEllipticalArcCommands I propose we do the same. We're trying to converge on SVG.
          Hide
          camilla.boemann Camilla Boemann (Inactive) added a comment -

          I just checked Calligra code - we use them as radii and have seemingly always done so - at least since 2011

          the table in 19.145 needs to reflect this though

          Show
          camilla.boemann Camilla Boemann (Inactive) added a comment - I just checked Calligra code - we use them as radii and have seemingly always done so - at least since 2011 the table in 19.145 needs to reflect this though
          Hide
          patrick Patrick Durusau added a comment -

          as per 28 Nov. 2016

          Show
          patrick Patrick Durusau added a comment - as per 28 Nov. 2016
          Hide
          regina.henschel Regina Henschel added a comment -

          Proposal:

          Change the syntax for command T and U

          from

          (x y w h t0 t1) +

          to

          (x y wR hR t0 t1) +

          and change the description in command T

          from

          The ellipse is specified by the center(x, y), the size(w, h) and the start-angle t0 in degrees and end-angle t1 in degrees.

          to

          The ellipse is specified by the center(x, y), the width 2*wR, the height 2*hR, and the start-angle t0 in degrees and end-angle t1 in degrees.

          -----------------

          I change the syntax from w to wR and h to hR to make the change better visible.

          Further problems are:

          The word "segment of ellipse" is misleading. No application draws a segment, but all draw an arc, and in case of filling, a filling in shape of a sector.

          The meaning of the angles it not clear. Examples: t0=0, t1=360 generates a full ellipse in applications. What rendering is expected for t0=-10, t1=350 (negative values), or for t0=350, t1=240 (start > end), of for t0=30, t1=480 (difference > 360) ?

          These problems can be addressed later. But the 'radius via diameter' mess should be addressed soon.

          Show
          regina.henschel Regina Henschel added a comment - Proposal: Change the syntax for command T and U from (x y w h t0 t1) + to (x y wR hR t0 t1) + and change the description in command T from The ellipse is specified by the center(x, y), the size(w, h) and the start-angle t0 in degrees and end-angle t1 in degrees. to The ellipse is specified by the center(x, y), the width 2*wR, the height 2*hR, and the start-angle t0 in degrees and end-angle t1 in degrees. ----------------- I change the syntax from w to wR and h to hR to make the change better visible. Further problems are: The word "segment of ellipse" is misleading. No application draws a segment, but all draw an arc, and in case of filling, a filling in shape of a sector. The meaning of the angles it not clear. Examples: t0=0, t1=360 generates a full ellipse in applications. What rendering is expected for t0=-10, t1=350 (negative values), or for t0=350, t1=240 (start > end), of for t0=30, t1=480 (difference > 360) ? These problems can be addressed later. But the 'radius via diameter' mess should be addressed soon.
          Hide
          patrick Patrick Durusau added a comment -

          Use Regina's prose later in comment for ODF 1.3

          Show
          patrick Patrick Durusau added a comment - Use Regina's prose later in comment for ODF 1.3
          Hide
          patrick Patrick Durusau added a comment -

          Applied OpenDocument-v1.3-wd13-04-part3-documents.odt

          Show
          patrick Patrick Durusau added a comment - Applied OpenDocument-v1.3-wd13-04-part3-documents.odt
          Hide
          michaelst Michael Stahl [X] (Inactive) added a comment -

          (copying reslolution to the jira field)

          Show
          michaelst Michael Stahl [X] (Inactive) added a comment - (copying reslolution to the jira field)

            People

            • Assignee:
              Unassigned
              Reporter:
              thorsten Thorsten Zachmann (Inactive)
            • Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: