Details

    • Proposal:
      Hide

      Change last paragraph of section 16.2 from

      "In all other cases, or if a value for the formatting property has not been found by any of the family specific rules, a default style 16.4 that has the same family as the style initially declared sets the value. If there is no value specified in that default style, an implementation-dependent value is used."

      to

      "In all other cases, or if a value for the formatting property has not been found by any of the family specific rules, a default style 16.4 that has the same family as the style initially declared sets the value.
      If a value has not been found by these steps, but this specification defines a default value, than this default value is used. In all remaining cases an implementation-dependent value is used."

      Show
      Change last paragraph of section 16.2 from "In all other cases, or if a value for the formatting property has not been found by any of the family specific rules, a default style 16.4 that has the same family as the style initially declared sets the value. If there is no value specified in that default style, an implementation-dependent value is used." to "In all other cases, or if a value for the formatting property has not been found by any of the family specific rules, a default style 16.4 that has the same family as the style initially declared sets the value. If a value has not been found by these steps, but this specification defines a default value, than this default value is used. In all remaining cases an implementation-dependent value is used."

      Description

      http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#element-style_style
      Chapter 20 contains attributes and elements of <style:*-properties> elements. These are child elements of the <style:style> element. As such they are subject of the inheritance described in section 16.2. If an attribute does not exist in the <style:style> element, which is referenced from the element, which is to be formatted, the value is used, which you get by the inheritance algorithm. The last level in the inheritance chain is described as “If there is no value specified in that default style, an implementation-dependent value is used.“

      But some of the items in chapter 20 have wordings like “The default value is 90deg.” (20.2 chart:angle-offset) or “The default value is true if svg:width and svg:height attributes are not specified.” (20.4 chart:auto-size)

      What does “default” mean in context of inheritance? It cannot mean, that the “default” is used, if the <style:style> element, which is referenced by the element, has no formatting information for this formatting aspect, because that would contradict the desired inheritance.
      It can mean, that on the last level of inheritance the “default” value is used. But currently that is not specified.

      This proposal adds a rule about such "default" values to section 16.2 <style:style>

        Attachments

          Activity

          Hide
          svante.schubert#1#1 svante.schubert#1#1 added a comment -

          You are right that the default values from the spec are not taken into account.

          You should still take into account that aside of the explicit style hierarchy provided by <style:style> elements referenced by parent, there is the implicit default style set for each style:family provided by <style:default-style>
          see http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#element-style_default-style

          All default values within the ODF 1.2 specification are being 'flagged' by a certain character style. With this metadata it is possible to extract all default values from the specification via XSLT.
          We might want to add the XSL script to the ODF TC repository as part of a new regression test to be certain that all default values are kept extractable.
          For a list of the default values with its values, take a look at the end part of the following config file:
          http://svn.apache.org/viewvc/incubator/odf/trunk/generator/schema2template/src/main/resources/examples/odf/config.xml?revision=1167956&view=markup

          In this context, a short question: Is there are list of pointers to the list of the implementation-dependent default values? I stumbled today over the fo:page-width and fo:page-height being both optional, so you might set only one for the page layout. What other value is being taken for the rectangle being the page, when only one value width or height of the page is being provided? Is there a local dependent default like US & Canda using letter format while the rest ISO A4?
          I would be curious of a coverage of format attributes by defaults from spec or implementation...

          Show
          svante.schubert#1#1 svante.schubert#1#1 added a comment - You are right that the default values from the spec are not taken into account. You should still take into account that aside of the explicit style hierarchy provided by <style:style> elements referenced by parent, there is the implicit default style set for each style:family provided by <style:default-style> see http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#element-style_default-style All default values within the ODF 1.2 specification are being 'flagged' by a certain character style. With this metadata it is possible to extract all default values from the specification via XSLT. We might want to add the XSL script to the ODF TC repository as part of a new regression test to be certain that all default values are kept extractable. For a list of the default values with its values, take a look at the end part of the following config file: http://svn.apache.org/viewvc/incubator/odf/trunk/generator/schema2template/src/main/resources/examples/odf/config.xml?revision=1167956&view=markup In this context, a short question: Is there are list of pointers to the list of the implementation-dependent default values? I stumbled today over the fo:page-width and fo:page-height being both optional, so you might set only one for the page layout. What other value is being taken for the rectangle being the page, when only one value width or height of the page is being provided? Is there a local dependent default like US & Canda using letter format while the rest ISO A4? I would be curious of a coverage of format attributes by defaults from spec or implementation...
          Hide
          regina.henschel Regina Henschel added a comment -

          Hi Svante, the linked list is about default values of attributes, which belong to an element. That are those from chapter 19 and are not effected by inheritance. My proposal is about "default" values in styles. Those are in chapter 20.

          I have found these attributes, for which the text contains something about a "default" value of the attribute:
          20.2 chart:anble-offset
          20.3 chart:auto-position
          20.4 chart:auto-size
          20.8 chart:data-label-number
          20.13 chart:error-category
          20.25 chart:include-hidden-cells
          20.35 chart:logarithmic
          20.43 chart:regression-type
          20.44 chart:reverse-direction
          20.64 chart:treat-empty-cells
          20.66 chart:visible
          20.77 dr3d:end-angle
          20.125 draw:frame-margin-horizontal
          20.127 draw:frame-margin-vertical
          20.130 draw:gradient-step-count
          20.258 style:first-page-number
          20.292 style:join-border
          20.326.3 style:protect in <style:section-properties>
          20.353 style:table-centering
          20.354 style:text-align-source
          20.386.1 style:vertical-align in <style:paragraph-properties>
          20.417 text:display
          20.421 text:list-level-position-and-space-mode

          Show
          regina.henschel Regina Henschel added a comment - Hi Svante, the linked list is about default values of attributes, which belong to an element. That are those from chapter 19 and are not effected by inheritance. My proposal is about "default" values in styles. Those are in chapter 20. I have found these attributes, for which the text contains something about a "default" value of the attribute: 20.2 chart:anble-offset 20.3 chart:auto-position 20.4 chart:auto-size 20.8 chart:data-label-number 20.13 chart:error-category 20.25 chart:include-hidden-cells 20.35 chart:logarithmic 20.43 chart:regression-type 20.44 chart:reverse-direction 20.64 chart:treat-empty-cells 20.66 chart:visible 20.77 dr3d:end-angle 20.125 draw:frame-margin-horizontal 20.127 draw:frame-margin-vertical 20.130 draw:gradient-step-count 20.258 style:first-page-number 20.292 style:join-border 20.326.3 style:protect in <style:section-properties> 20.353 style:table-centering 20.354 style:text-align-source 20.386.1 style:vertical-align in <style:paragraph-properties> 20.417 text:display 20.421 text:list-level-position-and-space-mode
          Hide
          patrick Patrick Durusau added a comment -

          Applied: OpenDocument-v1.3-wd04-part3-documents.odt

           

          Show
          patrick Patrick Durusau added a comment - Applied: OpenDocument-v1.3-wd04-part3-documents.odt  

            People

            • Assignee:
              Unassigned
              Reporter:
              regina.henschel Regina Henschel
            • Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: